Review of "Just shows memory usage" version 8

Details Page Preview

Just shows memory usage

Extension Homepage
https://github.com/troizet/just-shows-memory-usage

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:65
    GLib.file_get_contents("/proc/meminfo")

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:44
            this._label = new St.Label({
                text: 'Just memory usage',
                y_align: Clutter.ActorAlign.CENTER,
                style_class: 'panel-button',
                track_hover: false,
                reactive: false
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:31
            this._settings.connect('changed::digits', (settings, key) => {
                this._digits = settings.get_uint(key);
            })
  • extension.js:35
            this._settings.connect('changed::timeout', (settings, key) => {
                GLib.source_remove(this._timeout);
    
                this._timeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, settings.get_uint(key), () => {
                    this._refresh();
                    return true;
                });
      

All Versions

Version Status
8 Rejected
7 Active
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Active
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages.