Review of "Chips Weather" version 5

Details Page Preview

Panel indicator showing current temperature and weather icon. Popup menu displays an 8-hour hourly forecast with temperature, UV index, precipitation probability, and color-coded temps. Daily view with high/low temperatures and dual weather icons for mixed conditions. Automatic location detection via IP. Supports Celsius/Fahrenheit.

Extension Homepage
https://github.com/ninjabucket/Chips-Weather

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:128
    this._box = new St.BoxLayout({style_class: 'panel-status-menu-box'})
  • extension.js:129
            this._icon = new St.Icon({
                icon_name: 'weather-clear-symbolic',
                style_class: 'system-status-icon',
            })
  • extension.js:133
            this._label = new St.Label({
                text: '--°',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'padding: 0 4px;',
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:542
                GLib.timeout_add(GLib.PRIORITY_DEFAULT, 10, () => {
                    let fi = 0;
                    const fiSteps = 6;
                    this._rebuildFadeInId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 15, () => {
                        fi++;
                        if (this._bgContainer) {
              
  • extension.js:922
                GLib.timeout_add(GLib.PRIORITY_DEFAULT, 10, () => {
                    let fi = 0;
                    const fiSteps = 6;
                    this._rebuildFadeInId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 15, () => {
                        fi++;
                        if (this._bgContainer) {
              

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:925
                    this._rebuildFadeInId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 15, () => {
                        fi++;
                        if (this._bgContainer) {
                            this._bgContainer.opacity = Math.round(255 * (fi / fiSteps));
                        }
                        if (fi >=

All Versions

Version Status
11 Unreviewed
10 Active
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

ninjabucket posted a review
JustPerfection rejected
Version 9 reviewed.