Review of "Memento Mori" version 5

Details Page Preview

Reminds you how much of the day, month, year and life is left in the menu bar

Extension Homepage
https://github.com/vedesh-padal/memento-mori-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:121
    this._countdownItem = countdownContainer
  • extension.js:115
        this._countdownLabel = new St.Label({
          text: '',
          x_expand: true,
          x_align: Clutter.ActorAlign.CENTER,
        })
  • extension.js:39
        this._hourglassLabel = new St.Label({
          text: '⏳ ',
          y_align: Clutter.ActorAlign.CENTER,
        })
  • extension.js:33
        this._panelBox = new St.BoxLayout({
          style_class: 'memento-mori-panel-box',
          y_align: Clutter.ActorAlign.CENTER,
        })
  • extension.js:57
        this._placeholderLabel = new St.Label({
          text: 'memento mori.',
          y_align: Clutter.ActorAlign.CENTER,
        })

All Versions

Version Status
5 Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active