Review of "TasksBar Custom" version 1

Details Page Preview

Taskbar with window icons in the top/bottom panel. Features: • Mini icons of open windows • Scrollable icon zone (mouse wheel) — no overflow • Configurable accent color • Configurable icon size • Configurable opacity (focused / unfocused) • Focus indicator bar under icon • Hover tooltip with window title • Click: activate / minimize • Middle click: new window • Scroll on panel: change workspace • Panel position: top or bottom • Compatible GNOME Shell 43-48+

Extension Homepage
https://github.com/Carmi/tasks-bar-custom

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:51
            this._label = new St.Label({
                text,
                style_class: 'task-tooltip',
                opacity: 0,
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:495
    this._settings = this.getSettings()
  • extension.js:420
    this._zone = new TaskScrollZone(settings)

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:58
            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                if (!this._label) return GLib.SOURCE_REMOVE;
                try {
                    const [x, y] = sourceActor.get_transformed_position();
                    const [w]    = sourceActor.get_transformed_size();
                    this._label.set_po
  • extension.js:313
                GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                    this._recalcWidth();
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

Carmi@Linux auto- rejected
Auto-rejected because of new version 2 was uploaded