Review of "Sticky Media" version 1

Details Page Preview

Place floating images and animated GIFs on your desktop

Extension Homepage
https://github.com/Gatalina-delcampo/sticky-media

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:39
    f.load_contents(null)
  • extension.js:130
    file.load_bytes(null)

EGO-I-002 error

Gtk, Gdk and Adw must not be imported in shell process files

GTK library `Gdk` must not be imported in extension process files.

Do not import GTK libraries in GNOME Shell

  • extension.js:22
    import Gdk from 'gi://Gdk?version=4.0';

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:73
    this._drawArea = new St.DrawingArea({ reactive: false, x: 0, y: 0 })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:73
    this._drawArea = new St.DrawingArea({ reactive: false, x: 0, y: 0 })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:78
            this._drawArea.connect('repaint', () => {
                if (!this._currentPixbuf) return;
                const cr = this._drawArea.get_context();
                const pw = this._currentPixbuf.get_width();
                const ph = this._currentPixbuf.get_height();
                const alloc = this._drawAr

All Versions

Version Status
1 Unreviewed