Review of "Custom Touchpad Gestures" version 1

Details Page Preview

Deeply customize 3 and 4-finger touchpad gestures.

Extension Homepage
https://github.com/Aradhya03/Touchpad-Gestures-Win

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 24 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:68
    console.log(`${LOG} Enabling extension...`)
  • extension.js:101
    console.log(`${LOG} startup-complete — re-disabling trackers`)
  • extension.js:127
    console.log(`${LOG} Extension enabled successfully`)
  • extension.js:131
    console.log(`${LOG} Disabling extension...`)
  • extension.js:153
    console.log(`${LOG} Extension disabled`)
  • extension.js:314
    console.log(`${LOG} Swipe: ${key} (dx=${this._dx.toFixed(1)}, dy=${this._dy.toFixed(1)}, n=${n})`)
  • extension.js:324
    console.log(`${LOG} Tap (from swipe): ${key} (n=${n})`)
  • extension.js:359
    console.log(`${LOG} Tap: ${key} (n=${this._holdFingers}, ${elapsed.toFixed(0)}ms)`)
  • extension.js:395
    console.log(`${LOG} Tap (via button ${button}): ${key}`)
  • extension.js:420
    console.log(`${LOG} Action: ${key} → type=${actionType}`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:315
                        GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                            this._executeAction(key);
                            return GLib.SOURCE_REMOVE;
                        })
  • extension.js:325
                            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                                this._executeAction(key);
                                return GLib.SOURCE_REMOVE;
                            })
  • extension.js:360
                        GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                            this._executeAction(key);
                            return GLib.SOURCE_REMOVE;
                        })
  • extension.js:396
                        GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                            this._executeAction(key);
                            return GLib.SOURCE_REMOVE;
                        })

All Versions

Version Status
1 Unreviewed