Review of "WeatherPanel" version 4

Details Page Preview

A modern GNOME Shell weather extension with detailed current conditions, hourly and multi-day forecasts, and offline awareness.

Extension Homepage
https://github.com/attentivecoder/weatherpanel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
9 Active
8 Rejected
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

attentivecoder posted a review
Fixed Shexli issues.
JustPerfection rejected
1. `this._destroyed` is a bad practice. Please avoid using them. Your instance should be destroyed and null out so it won't be accessed after destroy. 2. Better to use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. Please remove `version`. GNOME Shell 45+ already using Soup version 3: - line 3 `services/geolocation.js` - line 4 `providers/baseProvider.js` 4. You should call `abort()` on disable or destroy: - line 22 `services/geolocation.js` - line 18 `providers/baseProvider.js` [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort)