Review of "Fullscreen MaxBright" version 3

Details Page Preview

Automatically sets brightness to maximum when watching fullscreen videos and restores the previous setting when exiting.

Extension Homepage
https://github.com/visnudeva/fullscreen-maxbright

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:119
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, SETTLE_DELAY_MS, () => {
                if (this._brightnessBeforeSleep >= 0) {
                    // Temporarily suppress _onBrightnessChanged so the hardware-reset
                    // value doesn't overwrite the snapshot we took before sleep.
                  

All Versions

Version Status
7 Active
6 Rejected
5 Rejected
4 Inactive
3 Rejected
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on disable and before creating a new one (line 119 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. Remove unnecessary try-catch (line 254 `extension.js`). 3. `donate` key is wrong. The correct way of adding `donation` to the `metadata.json`: ```json "donations": { "kofi": "visnu_deva" }, ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions