GNOME Shell Extensions

Review of "Focus" version 18

Details Page Preview

Focus

by scaryrawr

Transparent inactive windows

Extension Homepage
https://github.com/scaryrawr/gnome-focus
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:23 
    GLib.file_get_contents(file_path)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

All Versions

Version Status
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Rejected
11 Rejected
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup.