GNOME Shell Extensions

Review of "Luna - Moon Phase Indicator" version 10

Details Page Preview

Luna - Moon Phase Indicator

by roy.thande

Displays current moon phase using astronomical calculations. Works offline.

Extension Homepage
https://github.com/thanderoy/luna
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

All Versions

Version Status
12 Active
11 Rejected
10 Rejected
9 Active
8 Rejected
7 Rejected
6 Inactive
5 Rejected
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

roy.thande auto- rejected
Auto-rejected because of new version 11 was uploaded
JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. What's the reason for those try-catch wrappers in `utils/moonPhaseIndicator.js`? Your XML has the keys. No need for any of those try-catch wrappers.