Review of "DM Theme Changer Reborn" version 1

Details Page Preview

Automatically change theme styles when dark mode is enabled or disabled.

Extension Homepage
https://github.com/phenrique-coder/DmThemeChanger

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:33
        this._sourceIds.interfaceSettings = this._interfaceSettings.connect(
          "changed",
          this._onInterfaceSettingsChanged.bind(this)
        )

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:91
        this._sourceIds.changeIconsDelayTimeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 1000, () => {
          this._changeCursorTheme(isDm ? CURSOR_THEME_DARK : CURSOR_THEME_LIGHT);
          this._changeIconTheme(isDm ? ICON_THEME_DARK : ICON_THEME_LIGHT);
          this.optimizeTransition.inProgress = false;
    

All Versions

Version Status
1.0.0 (6) Unreviewed
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

phenrique.coder posted a review
phenrique.coder auto- rejected
Auto-rejected because of new version 2 was uploaded