Review of "Carmenta" version 6

Details Page Preview

Companion extension for Carmenta - The connection bridge allowing text insertion (requires Carmenta app). This extension writes text to the clipboard to perform insertion.

Extension Homepage
https://github.com/szymonwilczek/carmenta

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:223
    St.Clipboard.get_default()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 14 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:41
    console.log("Carmenta: Enabling extension")
  • extension.js:54
    console.log("Carmenta: Extension enabled")
  • extension.js:58
    console.log("Carmenta: Disabling extension")
  • extension.js:91
    console.log(`Carmenta: Acquired name ${name}`)
  • extension.js:94
    console.log(`Carmenta: Lost name ${name}`)
  • extension.js:157
    console.log("Carmenta: Window set to ALWAYS ON TOP + STICKY")
  • extension.js:163
    console.log("Carmenta: Window not found for pinning")
  • extension.js:168
    console.log(`Carmenta: Injecting text '${text}'`)
  • extension.js:199
    console.log("Carmenta: Focus returned")
  • extension.js:209
    console.log("Carmenta: No last focused window found")

All Versions

Version Status
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active