Review of "Launcher" version 15

Details Page Preview

Launch scripts from a panel indicator

Extension Homepage
https://github.com/hedgieinsocks/gnome-extension-launcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:151
    this._menu = new ScrollableMenu()

All Versions

Version Status
16 Active
15 Rejected
14 Inactive
13 Inactive
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages.