Review of "Simple Break Reminder" version 21

Details Page Preview

It's important to remember to take a break

Extension Homepage
https://github.com/CastilloDel/simplebreakreminder

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:138
    this._notification.connect('activated', postpone)
  • extension.js:141
                this._notification.connect('destroy', () => {
                    if (this._notification_alive === true) {
                        postpone();
                    }
                })
  • extension.js:83
            this._settings.connect('changed::time-between-breaks', () => {
                this._in_extension = false;
                this.resetTimer(this._settings.get_uint('time-between-breaks'));
            })

All Versions

Version Status
22 Active
21 Rejected
20 Active
19 Active
18 Active
17 Rejected
16 Active
15 Active
14 Rejected
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Inactive
5 Active
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

CastilloDel auto- rejected
Auto-rejected because of new version 22 was uploaded