Review of "TOTP Authenticator" version 2

Details Page Preview

A native TOTP authenticator for the GNOME desktop. Add accounts via QR code or manual entry, view live auto-refreshing OTP codes, and keep secrets stored securely in GNOME Keyring.

Extension Homepage
https://github.com/talhasiddique7/totp

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4 manual_review 1

Shexli found 5 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/accountManager.js:63
    file.load_contents(null)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • ui/accountRow.js:368
    St.Clipboard.get_default()
  • ui/accountRow.js:426
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • lib/otpauth.js
  • ui/progressArc.js

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • lib/secretStorage.js:9
    new Secret.Schema(
        'org.gnome.shell.extensions.gnome-totp-authenticator',
        Secret.SchemaFlags.NONE,
        {
            'account-id': Secret.SchemaAttributeType.STRING,
        }
    )
  • lib/secretStorage.js:18
    new Secret.Schema(
        'org.gnome.shell.extensions.totp-auth',
        Secret.SchemaFlags.NONE,
        {
            'account-id': Secret.SchemaAttributeType.STRING,
        }
    )

All Versions

Version Status
7 Unreviewed
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Talha Siddique auto- rejected
Auto-rejected because of new version 3 was uploaded