Review of "My Vision" version 13

Details Page Preview

MyVision is a fork of Display Configuration Switcher that has been thoughtfully and substantially enhanced. It allows users to store profiles that are directly bound to specific display devices. This approach eliminates the need for redundant profiles in scenarios where video outputs are detected or ordered unpredictably.

Extension Homepage
https://github.com/tomasmark79/my-vision

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:226
    console.warn(`WARNING: Hash collision detected! Hashes match but physical displays differ.`)
  • extension.js:181
    console.error('Failed to load default monitor configuration:', err)
  • extension.js:210
    console.error('Failed to apply monitor configuration:', err)
  • extension.js:348
    console.error('Failed to apply first monitor configuration:', error)
  • extension.js:366
    console.error('Failed to cycle monitor configuration:', error)
  • extension.js:391
    console.error('Error applying monitor configuration:', error)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:71
                this._settings.connect('changed::display-configuration-switcher-shortcuts-enabled', (settings, key) => {
                    this._updateKeyBindings();
                })

All Versions

Version Status
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active