Review of "Input Remapper Control" version 4

Details Page Preview

Activate your Input Remapper presets from the GNOME top bar

Extension Homepage
https://github.com/agc93/gnome-input-remapper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • extension.js:126
    stopSeparator = new PopupMenu.PopupSeparatorMenuItem()
  • extension.js:127
    this._stopAction = new PopupMenu.PopupMenuItem('Stop')
  • extension.js:128
            this._stopAction.connect('activate', () => {
                this.stopInjectingForDevice();
            })
  • extension.js:131
            this._stopAction.connect('hide', () => {
                stopSeparator.hide();
            })
  • extension.js:134
            this._stopAction.connect('show', () => {
                stopSeparator.show();
            })
  • extension.js:46
    titleItem = new PopupMenu.PopupSeparatorMenuItem("State: ")
  • extension.js:47
    this._stateLabel = new St.Label({ text: this.deviceState })
  • extension.js:47
    new St.Label({ text: this.deviceState })

All Versions

Version Status
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active