Review of "True USB Write Progress" version 1

Details Page Preview

A top-bar widget that monitors real-time pending background writes to removable USB storage, showing true dirty-cache flush progress so you know exactly when a drive is safe to eject.

Extension Homepage
https://github.com/ktauchathuranga/true-usb-progress

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:76
    GLib.file_get_contents(path)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:211
            this._icon = new St.Icon({
                icon_name   : 'drive-removable-media-usb-symbolic',
                style_class : 'system-status-icon',
            })
  • extension.js:217
            this._label = new St.Label({
                text        : '',
                y_align     : Clutter.ActorAlign.CENTER,
                style       : 'margin-left: 4px; font-weight: bold;',
            })

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

Ashen Chathuranga auto- rejected
Auto-rejected because of new version 2 was uploaded