Review of "Weekly Commits" version 11

Details Page Preview

See your weekly GitHub, Gitea / Forgejo or GitLab commits in the top bar

Extension Homepage
https://github.com/funinkina/weekly-commits

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-001 manual_review

extension code must not be minified or obfuscated

File appears obfuscated: 61% of identifiers are 1–2 characters (avg length 2.8).

Code must not be obfuscated

  • helpers/colorUtils.js
    short identifier ratio: 61%, identifiers scored: 124

All Versions

Version Status
12 Active
11 Rejected
10 Active
9 Rejected
8 Active
7 Inactive
6 Inactive
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. You cannot create instance of objects in global scope and leave it there after disable (line 7 `helpers/http.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. You should call `abort()` on disable or destroy (line 7 `helpers/http.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 4. Pleas don't wrap `destroy()` with try-catch.