Review of "Zen" version 11

Details Page Preview

Various tweaks for a more predictable Gnome shell experience

Extension Homepage
https://github.com/leotaku/zen

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection active
Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup.
leotaku posted a review
Is the correct/idiomatic way to do this to just pass in the extension object to these functions?
JustPerfection posted a review
Yes, you can do that. For example, instead of line 44-60 `extension.js` use `connectObject()` with `this` and then, in disable simply do this: ```js this.settings.disconnectObject(this); ```