Review of "App Grid Button In Top Panel" version 5

Details Page Preview

Adds a button beside the Activities button that opens the app grid directly.

Extension Homepage
https://github.com/raphaelian-dev/appgridbuttonintoppanel-raphaelian

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:62
    this._clickGesture = new Clutter.ClickGesture()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:62
    this._clickGesture = new Clutter.ClickGesture()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:63
            this._clickGesture.connect('recognize', () => {
                toggleAppGrid();
            })

All Versions

Version Status
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active