Review of "Raccoon Launcher" version 1.0.0 (1)

Details Page Preview

A fast, keyboard-driven launcher overlay for GNOME Shell. Search and launch apps, evaluate math, run quick web searches, and trigger system actions — all from one hotkey. The calculator copies its result to the clipboard when you press Enter.

Extension Homepage
https://github.com/shimafallah/raccoon-launcher

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • lib/providers/calc.js:33
    St.Clipboard.get_default()

All Versions

Version Status
1.0.0 (2) Active
1.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove line 7-25 `prefs.js`. Not needed. And where did you get the info mentioned in line 7-8 comment? You only need this: ```js import {ExtensionPreferences} from 'resource:///org/gnome/Shell/Extensions/js/extensions/prefs.js'; ``` 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. The commands you are doing in `lib/providers/system.js` shouldn't be used as `Subprocess`. For example: ```js import * as SystemActions from 'resource:///org/gnome/shell/misc/systemActions.js'; let systemActions = new SystemActions.getDefault(); // The actions you want systemActions.activateLockScreen(); systemActions.activateSuspend(); systemActions.activateRestart(); systemActions.activatePowerOff(); systemActions.activateLogout(); ``` [EGO Review Guidelines: GJS](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#scripts-and-binaries) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Shima posted a review
Fixed all three points Removed the dynamic import block in prefs.js/using the direct import now Switched to connectObject()/disconnectObject() for all signal connections Replaced Subprocess calls with SystemActions (activateLockScreen, etc) New version uploaded Thanks for the review