Review of "AwakeGuard" version 2

Details Page Preview

Keep your system awake intelligently, not permanently.

Extension Homepage
https://github.com/devdilshad92-dot/awakeguard

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. Is there any situation `global.display` isn't going to be there? Asking that because you are checking that in `services/BaseDetector.js` many times. 3. Please move line 21 `services/InhibitorService.js` to the `InhibitorService`. 4. You cannot use spawn command to play sound (line 27 `services/NotificationService.js`). Use this instead: ```js let player = global.display.get_sound_player(); let file = Gio.File.new_for_path('PATH TO THE FILE'); player.play_from_file(file, 'title', null); ``` Or play audio form theme: ```js player.play_from_theme('sound name', 'title', null); ``` 5. Timeout should be removed before creating a new one (line 35 `services/StreamingDetector.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Dilshad posted a review
fixed the review changes
Dilshad posted a review
fixed the review changes