Review of "Text Scaler" version 21

Details Page Preview

Simple extension to easily define arbitrary values for the text scaling factor

Extension Homepage
https://github.com/mariospr/text-scaler-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:70
    this._entry = new St.Entry()
  • extension.js:66
    this._menuItem = new PopupMenu.PopupBaseMenuItem({ activate: true })
  • extension.js:90
    this._resetValueItem = new PopupMenu.PopupMenuItem(_("Reset to default value"))
  • extension.js:87
    this._separatorItem = new PopupMenu.PopupSeparatorMenuItem()
  • extension.js:48
    this.actor = new PanelMenu.Button(0.0, "Text Scaler Button")

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:70
    this._entry = new St.Entry()
  • extension.js:66
    this._menuItem = new PopupMenu.PopupBaseMenuItem({ activate: true })
  • extension.js:90
    this._resetValueItem = new PopupMenu.PopupMenuItem(_("Reset to default value"))
  • extension.js:87
    this._separatorItem = new PopupMenu.PopupSeparatorMenuItem()
  • extension.js:52
    this._settings = new Gio.Settings({ schema_id: 'org.gnome.desktop.interface' })
  • extension.js:48
    this.actor = new PanelMenu.Button(0.0, "Text Scaler Button")

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:53
    this._settings.connect('changed::text-scaling-factor', (settings, key) => this._onSettingsChanged(settings, key))

All Versions

Version Status
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active