Review of "Lockscreen Studio" version 1.1.0 (4)

Details Page Preview

Customize your lock screen: control blur, custom text message, style clock/date size and fonts, and more.

Extension Homepage
https://github.com/phenrique-coder/lockscreen-studio

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • install.sh
    install.sh

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:546
                            this._lssBrightnessOverlay = new St.Widget({
                                reactive: false,
                            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:546
                            this._lssBrightnessOverlay = new St.Widget({
                                reactive: false,
                            })

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:635
        disable() {
            this._stopClockTimer();
    
            // Disconnect settings change listener
            if (this._settingsChangedId) {
                this._settings.disconnect(this._settingsChangedId);
                this._settingsChangedId = null;
            }
    
            // Restore original prototype methods
    

All Versions

Version Status
1.1.0 (5) Unreviewed
1.1.0 (4) Rejected
1.0.0 (3) Active
1.0.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

phenrique.coder auto- rejected
Auto-rejected because of new version 1.1.0 (5) was uploaded