Review of "Wiggly" version 7

Details Page Preview

Wiggly is a GNOME Shell extension that magnifies the cursor when the mouse is moved rapidly.

Extension Homepage
https://github.com/Arch-Lover/wiggly

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
8 Active
7 Rejected
6 Inactive
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
What's the reason for the check in line 29 `extension.js`? Shouldn't always have that?
MojArch posted a review
Well it is a check for GNOME Shell API compatibility across versions. I use it to detect the API style. My final goal was to use modern API if available and in case of unavailability fall back to older internal API.
JustPerfection posted a review
I mean shouldn't the watch always have `remove()` function in it in all 45+ GNOME Shells?
MojArch posted a review
I think so.
JustPerfection posted a review
If so, why aren't you just simply doing `watch?.remove();` instead of `if (typeof watch.remove === 'function') {`? I mean that makes the check useless. That function is always there. Since GNOME Shell 45: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/a5fa6111153068ec65ab88f206bfa1b6685c759f/js/ui/pointerWatcher.js#L34
MojArch posted a review
I wasn't sure about that so i gone defensive in case something happen. i'll make necessary changes and submit it again. thnx for your guide and patience.
MojArch auto- rejected
Auto-rejected because of new version 8 was uploaded