Review of "Snap Text" version 6

Details Page Preview

Grab text from anywhere on your screen with Snap Text, just like the popular macOS feature. Select any area, and it instantly extracts detected text with OCR and copies it to your clipboard. Works with images, screenshots, dialogs, documents, apps, and other places where normal text selection is not available. Can also instantly auto-translate. It aims to be the perfect tool for capturing unselectable text from images, documents, videos, and system dialogs.

Extension Homepage
https://github.com/cwittenberg/snaptext

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • dependencies.js:186
    St.Clipboard.get_default()
  • extension.js:252
    St.Clipboard.get_default()
  • extension.js:523
    St.Clipboard.get_default()

All Versions

Version Status
8 Active
7 Inactive
6 Rejected
5 Inactive
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

cwittenberg posted a review
- refactored ocr logic into separate file. Depending on image a different strategy is used for max accuracy - improved look/feel of tray menu - added QR code parsing capability
JustPerfection rejected
1. You should call `abort()` on disable or destroy (line 377 `extension.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 2. Better to don't export `getCombinedInstallCommand()` (line 32 `dependencies.js`) since it has `sudo` in it. That way reviewers can look into that one file to check where the `sudo` command has been used. You can even remove the `export` from `checkDependencies()` and only have a helper function like `getMissingAppsErrorDialog()`.