Review of "Steam Friends" version 1

Details Page Preview

Gnome Extensions to view Steam Friends List


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:72
    this._loadingItem = new PopupMenu.PopupMenuItem('Loading Steam friends...')
  • extension.js:56
    this._scrollSection = new PopupMenu.PopupMenuSection()
  • extension.js:58
            this._scrollView = new St.ScrollView({
                hscrollbar_policy: St.PolicyType.NEVER,     
                vscrollbar_policy: St.PolicyType.AUTOMATIC, 
                style_class: 'vfade',
                // FIXED: Added a structural min-width constraint so the container doesn't collapse into a th

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:72
    this._loadingItem = new PopupMenu.PopupMenuItem('Loading Steam friends...')

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:78
    this._soupSession = new Soup.Session()

All Versions

Version Status
1 Unreviewed