Review of "PIP-Lens" version 50.0 (1)

Details Page Preview

Allows you to create a Picture-in-Picture (PiP) view of any window

Extension Homepage
https://github.com/ivan-artdian/pip-lens

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.pip-lens.gschema.xml
    id='org.gnome.shell.extensions.window-thumbnails-old' path='/org/gnome/shell/extensions/window-thumnails/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:96
    this._gSettingsKBid = this.Me.opt.connect('changed::create-tmb-shortcut', this._updateKeyBinding.bind(this))
  • extension.js:40
            Me.opt.connect('changed', (settings, key) => {
                if (key.includes('shortcut'))
                    this._updateKeyBinding();
            })
  • winTmb.js:535
    this._draggable.connect('drag-cancelled', this._endDrag.bind(this))
  • winTmb.js:534
    this._draggable.connect('drag-end', this._endDrag.bind(this))
  • winTmb.js:1601
    this._draggable.connect('drag-cancelled', this._endDrag.bind(this))
  • winTmb.js:1600
    this._draggable.connect('drag-end', this._endDrag.bind(this))

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • winTmb.js:740
            this._timeouts.winResizeDelayId = GLib.timeout_add(
                500,
                GLib.PRIORITY_LOW,
                () => {
                    this._winGeometry = this._metaWin.get_frame_rect();
                    this._fixGeometry(apply);
                    this._updateCloneScale();
                    this
  • winTmb.js:1693
            this._timeouts.rebuildId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 50, () => {
                if (this._timeouts)
                    this._timeouts.rebuildId = 0;
                if (!this._tmbDestroyed)
                    this._buildClones();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
50.0 (1) Unreviewed