Review of "OopsiType" version 2

Details Page Preview

Instantly corrects text typed in the wrong keyboard layout (EN/FA). Uses native GNOME APIs to transliterate and replace selected text via a customizable shortcut. Designed specifically for Wayland.

Extension Homepage
https://github.com/Arch-Lover/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:69
    St.Clipboard.get_default()

All Versions

Version Status
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't need to use any parameters for `this.getSettings()` if you already have that in `metadata.json`: ```json "settings-schema": "org.gnome.shell.extensions.oopsitype", ``` 2. Please add to the description that this extension is using clipboard: [EGO Review Guidelines: Clipboard](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#clipboard-access-must-be-declared) 3. What's the reason for all of these nested timeouts? You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
4. Please add GitHub or GitLab repo url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed)