Review of "RSS Feed" version 7

Details Page Preview

A modern GNOME Shell extension for following your favorite feeds right from the notification bar. Featuring two layout modes, notifications, and a fully editable list of RSS, Atom, and RDF sources. Features: - Classic and Minimal layout - Panel unread badge, with mark as read function - Desktop notifications (lock screen optional) - Article update detection (re-notifies on changed content) - Relative timestamps - Copy URL action in notifications, or right click on article - Feed management with drag-n-drop - Per-feed mute notifications - Custom feed title and avatar - Configurable refresh and article limit - Notification limit and optional auto-cleanup on disable - Persistent read state across shell restarts - RSS, Atom, RDF and FeedBurner format - Multi-charset feed support (UTF-8, ISO-8859, etc.) Extension writes to clipboard only when the user explicitly requests to copy a feed article URL.

Extension Homepage
https://github.com/todevelopers/gnome-shell-extension-rss-feed

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:1084
    St.Clipboard.get_default()
  • extensiongui/rssminimalmenuitem.js:53
    St.Clipboard.get_default()
  • extensiongui/rsspopupmenuitem.js:58
    St.Clipboard.get_default()

All Versions

Version Status
7 Active
6 Active
5 Active
4 Active
3 Active
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection active
1. Better to remove the timeout before creating a new one (line 712 `extension.js`). I know that you are in line 664 but still better to keep that close. Makes it more readable. 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup.