Review of "Monitor control using ddcutil" version 2

Details Page Preview

Control brightness, contrast, color temperature, RGB gain/black level and sharpness for all the monitors detected by ddcutil. This tool uses ddcutil as backend for communication with your display.

Extension Homepage
https://github.com/RHJihan/gnome-monitor-control-ddcutil

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • po/de.po
    po/de.po
  • po/es.po
    po/es.po
  • po/monitor-control-ddcutil.pot
    po/monitor-control-ddcutil.pot

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:925
            monitorSignals = {
                change: Main.layoutManager.connect('monitors-changed', this.onMonitorChange.bind(this)),
            }

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:432
    display.proxy.connect('g-properties-changed', () => sync())
  • extension.js:460
                item.connect('slider-change', (_item, value) => {
                    this.setControlValue(display, data, value);
                })

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

RHJihan posted a review