EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

• extension.js:69

  console.error(`AquaDock: failed to launch ${uri}: ${e}`)

• extension.js:2563

  console.error(`AquaDock: activation failed: ${e}`)

• extension.js:2681

  console.error(`AquaDock: reorder failed: ${e}`)

• extension.js:2804

  console.error(`AquaDock: pin-on-drop failed: ${e}`)

• extension.js:3147

  console.error(`AquaDock: launch failed: ${e}`)

• extension.js:3470

  console.error(`AquaDock: empty trash failed: ${e}`)

• extension.js:3751

  console.error(`AquaDock: in-place apply failed: ${e}`)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• extension.js:1620

  this._bg = new St.Widget({style_class: 'aqua-bg'})

• extension.js:2349

          this._frameTimeline = new Clutter.Timeline({
              actor: this._container,
              duration: 3600 * 1000,
          })

• extension.js:2936

  this._preview = box

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• extension.js:1620

  this._bg = new St.Widget({style_class: 'aqua-bg'})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:2353

          this._frameTimeline.connect('new-frame', () => {
              if (!this._animateFrame()) this._frameTimeline.stop();
          })

• extension.js:3369

          this._menu.connect('open-state-changed', (m, open) => {
              if (!open) {
                  GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                      if (this._menu === m) {
                          try { this._menuManager.removeMenu(m); } catch {}
                          try { m.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• extension.js:3371

                  GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                      if (this._menu === m) {
                          try { this._menuManager.removeMenu(m); } catch {}
                          try { m.destroy(); } catch {}
                          this._menu = null;
                      }