Review of "Persian Calendar" version 32

Details Page Preview

Fork of Gnome Calendar extension with Persian taste

Extension Homepage
https://github.com/IamRezaMousavi/persian-gnome-calendar-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • dateMenu.js:66
            this._calendar.connect('selected-date-changed', (_calendar, datetime) => {
                // Make the button reactive only if the selected date is not the
                // current date.
                this.reactive = !_isToday(_gDateTimeToDate(datetime));
            })
  • dateMenu.js:131
            this._appSys.connect('installed-changed',
                this._appInstalledChanged.bind(this))
  • extension.js:56
            this.settings.connect('changed::gregorian-events-active', () => {
                this.disable();
                this.enable();
            })
  • extension.js:64
            this.settings.connect('changed::hijri-events-active', () => {
                this.disable();
                this.enable();
            })
  • extension.js:50
            this.settings.connect('changed::indicator-index', () => {
                this.disable();
                this.enable();
            })
  • extension.js:46
            this.settings.connect('changed::indicator-position', () => {
                this.disable();
                this.enable();
            })
  • extension.js:68
            this.settings.connect('changed::international-events-active', () => {
                this.disable();
                this.enable();
            })
  • extension.js:60
            this.settings.connect('changed::persian-events-active', () => {
                this.disable();
                this.enable();
            })

All Versions

Previous Reviews on this Version

JustPerfection rejected
Please fix the Shexli warnings and send it again.