Review of "DuckDuckBang" version 5

Details Page Preview

Use Super key for quick web search and add custom !bangs. Combination of Quick Web Search and !Bangs Search

Extension Homepage
https://github.com/merijnvervoorn/duckduckbang

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:256
    file.load_contents(null)
  • extension.js:273
    bangsFile.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 19 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:57
    console.error('Failed to launch bang URL:', error)
  • extension.js:163
    console.error('Failed to launch URL:', error)
  • extension.js:262
    console.error('Failed to load search engines:', error)
  • extension.js:210
    console.warn('Failed to load search engine icon, using fallback:', error)
  • extension.js:93
    console.log(`BangsProvider getResultMetas called for results:`, results)
  • extension.js:106
    console.log(`BangsProvider returning ${resultMetas.length} result metas`)
  • extension.js:172
    console.log(`WebSearchProvider getInitialResultSet called with: "${input}"`)
  • extension.js:176
    console.log(`WebSearchProvider returning results:`, results)
  • extension.js:201
    console.log(`WebSearchProvider getResultMetas called for results:`, results)
  • extension.js:202
    console.log(`Using search engine index: ${searchEngine}`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
7 Active
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Fix the Shexli issues and send it again.