Review of "Custom Input Method Indicator" version 1

Details Page Preview

Customize CapsLock, English and Native input indicator text, font size, color and bold weight, pure native logic without hijacking GNOME keyboard widget.

Extension Homepage
https://github.com/huageek/custom-input-method-indicator

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Checking `if (ENABLE_LOG)` on each log is a bad practice. Better to create a helper function. 4. What throws that needs try-catch (line 21 `extension.js`)? You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions