EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• extension.js:161

  GLib.file_get_contents(this._configFile)

• extension.js:196

  GLib.file_get_contents(this._configFile)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• extension.js:81

  this._drawingArea = new St.DrawingArea({ x_expand: true, y_expand: true })

• extension.js:85

          this._timeLabel = new St.Label({
              x_align: Clutter.ActorAlign.CENTER,
              y_align: Clutter.ActorAlign.CENTER,
              x_expand: true,
              y_expand: true
          })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• extension.js:81

  this._drawingArea = new St.DrawingArea({ x_expand: true, y_expand: true })

• extension.js:85

          this._timeLabel = new St.Label({
              x_align: Clutter.ActorAlign.CENTER,
              y_align: Clutter.ActorAlign.CENTER,
              x_expand: true,
              y_expand: true
          })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:96

          this._container.connect('button-press-event', (actor, event) => {
              if (event.get_click_count() === 2) {
                  try {
                      let appInfo = Gio.AppInfo.create_from_commandline('gnome-clocks', null, Gio.AppInfoCreateFlags.NONE);
                      if (appInfo) 

• extension.js:121

          this._container.connect('button-release-event', () => {
              if (!isDragging) return Clutter.EVENT_PROPAGATE;
              isDragging = false;
              let [ax, ay] = this._container.get_position();
              this._writePositionToConfig(ax, ay);
              return Clutter.EVENT_ST

• extension.js:114

          this._container.connect('motion-event', (actor, event) => {
              if (!isDragging || !this._dragMode) return Clutter.EVENT_PROPAGATE;
              let [x, y] = event.get_coords();
              this._container.set_position(x - offsetOffsetX, y - offsetOffsetY);
              return Clutter.

• extension.js:82

  this._drawingArea.connect('repaint', (area) => this._onDraw(area.get_context()))

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

• prefs.js:12

  this._configFile = GLib.build_filenamev([this.path, 'config.json'])