Review of "Blackout" version 3

Details Page Preview

A lightweight GNOME Shell extension that displays a black screen after a period of user inactivity.

Extension Homepage
https://github.com/linuverse/blackout

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:161
    actor

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:151
                GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                    actor.ease({
                        opacity: 255,
                        duration: 3000,
                        mode: Clutter.AnimationMode.EASE_IN_OUT_SINE,
                    });
    
                    return GLib.SOURCE_REMOVE;
             

All Versions

Version Status
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

groovy posted a review
Upload for Gnome 49 and 50
JustPerfection active