Review of "Default Workspace" version 14

Details Page Preview

Switches to the specified workspace on login. Useful for workspace setups where the first workspace isn't the main one.

Extension Homepage
https://github.com/MateusRodCosta/gnome-shell-extension-default-workspace

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
15 Active
14 Rejected
13 Rejected
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Rejected
4 Active
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection active
JustPerfection rejected
JustPerfection rejected
Please don't send packages here without testing. The `connectObject()` needs 3rd parameter as `this`. Also line 25 should be `layoutManager.disconnectObject(this);`. And the checks on line 14 would be useless since `connectObject()` doesn't return signal id.
MateusRodCosta posted a review
My bad, I did logout and re-login and it did seem to work, so I might actually actually forgotten run the extension command with the install flag. I will leave the already accepted version for now and look into these other chnages later this week.
JustPerfection posted a review
Feel free to ping me on GitHub (`jrahmatzadeh`) or in GNOME Extensions Matrix channel. I can review the code before sending the packages here.