Review of "Workspace Flow" version 1

Details Page Preview

A focused GNOME workspace overview with labels, vertical stacking, and smooth workspace preview zoom.

Extension Homepage
https://gitlab.com/turnera-ca/workspace-flow

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.workspace-flow.gschema.xml
    id='org.gnome.shell.extensions.workspace-flow' path='/org.gnome.shell.extensions.workspace-flow/'

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:1044
            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                this._applyEntryWorkspaceRestore();
                return GLib.SOURCE_REMOVE;
            })
  • extension.js:1730
                GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                    if (!this._isExtensionActive())
                        return GLib.SOURCE_REMOVE;
    
                    if (button.checked) {
                        if (this._previewEffectsActive)
                            this._onUserShowAppsActivated();
    
  • extension.js:418
                    GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                        if (!this._isExtensionActive() || !this._verticalStack)
                            return GLib.SOURCE_REMOVE;
    
                        this._verticalStack.prepareAtWorkspaceOverview();
                        return GLib.SOURCE_RE
  • extension.js:910
                    GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                        if (
                            this._previewWorkspaceTrackingActive &&
                            !this._previewWorkspaceCommitted
                        ) {
                            this._freezeOverviewWorkspaceScroll();
          

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

movax auto- rejected
Auto-rejected because of new version 2 was uploaded