Review of "Stock Price Panel" version 1

Details Page Preview

Show a live stock price in the top panel with full customization for ticker, colors, data source, display format, and refresh rate.

Extension Homepage
https://github.com/psam21/strc-price-panel

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:15
            this._label = new St.Label({
                text: '--',
                y_align: Clutter.ActorAlign.CENTER,
                style_class: 'strc-price-panel-label',
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:70
            this._timeoutId = GLib.timeout_add_seconds(
                GLib.PRIORITY_DEFAULT,
                seconds,
                () => {
                    this._refresh();
                    return GLib.SOURCE_CONTINUE;
                }
            )

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:7
        getPreferencesWidget() {
            const settings = this.getSettings();
            const box = new Gtk.Box({
                orientation: Gtk.Orientation.VERTICAL,
                margin_top: 24,
                margin_bottom: 24,
                margin_start: 24,
                margin_end: 24,
                spacing: 12,

All Versions

Version Status
1 Unreviewed