Review of "Flags Input Indicator" version 2

Details Page Preview

Show country flags in the GNOME keyboard layout menu and top bar

Extension Homepage
https://github.com/eHab-codeX/flags-input-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:142
    this._timeoutId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 100, () => {
        this._tryHook();
        return true; // keep repeating
    })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

eHab-codeX auto- rejected
Auto-rejected because of new version 3 was uploaded