Review of "Active Window Layout" version 1

Details Page Preview

Provides a D-Bus API to move and resize the active window within the Work Area, intended for keyboard-driven workflows and external automation.

Extension Homepage
https://github.com/jidaikobo-shibata/active-window-layout

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please fix the indentation (line 273-284 `extension.js`). 2. Why not using prefs for configuring the shortcut instead of exposing d-bus? 3. D-Bus interface name should start with `org.gnome.Shell.Extensions`. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
jidaikobo-shibata posted a review
Thank you for the review. I addressed the issues in version 2: 1. Fixed the indentation in extension.js. 2. Changed the D-Bus interface name, bus name, and object path to use the org.gnome.Shell.Extensions namespace: - org.gnome.Shell.Extensions.jidaikobo.shibata.ActiveWindowLayout - /org/gnome/Shell/Extensions/jidaikobo/shibata/ActiveWindowLayout I included the author namespace to avoid collisions while following the required org.gnome.Shell.Extensions prefix. 3. About prefs: this extension is not intended to configure GNOME Shell keyboard shortcuts directly. It provides a D-Bus API for external automation tools and key remappers, such as xremap. I updated the README examples and CHANGELOG to make the D-Bus API usage and the breaking name change clearer. I also tested the updated D-Bus name with xremap on GNOME Shell 50. I did not add donations for now. The new package uses metadata version 2 and was checked with shexli: shexli: clean (0 findings, 0 errors, 0 warnings)
JustPerfection posted a review
By prefs I mean the extension settings for assigning keyboard shortcuts not GNOME settings: https://gjs.guide/extensions/development/preferences.html
jidaikobo-shibata posted a review
About prefs: thanks for clarifying. I understand you meant an extension preferences UI for assigning shortcuts. This extension is currently focused on exposing a D-Bus API for external automation tools such as xremap, but I will consider adding built-in shortcut preferences in a future version.