Review of "Squircle Desktop Clock" version 1

Details Page Preview

An elegant, customizable floating digital desktop clock widget with drag-and-drop placement positioning.

Extension Homepage
https://github.com/SANJAY-N0/squircle-desktop-clock

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:108
            this._container.connect('button-press-event', (actor, event) => {
                if (event.get_click_count() === 2) {
                    this._cleanupStageDrag(); 
                    try {
                        let appInfo = Gio.AppInfo.create_from_commandline('gnome-clocks', null, Gio.AppInfoCreateFla

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:14
    this._configFile = GLib.build_filenamev([this.path, 'config.json'])

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

addams auto- rejected
Auto-rejected because of new version 2 was uploaded