GNOME Shell Extensions

Review of "Kube Config" version 2

Details Page Preview

Kube Config

by MochaCaffe

Switches kube config context

Extension Homepage
https://github.com/MochaCaffe/gnome-shell-extension-kubeconfig.git
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.kube_config.gschema.xml 
    id='org.gnome.shell.extensions.kube-config' path='/org/gnome/shell/extensions/kube-config/'

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • lib/yaml/Dumper.js
  • lib/yaml/Escaper.js
  • lib/yaml/Exception/DumpException.js
  • lib/yaml/Exception/ParseException.js
  • lib/yaml/Exception/ParseMore.js
  • lib/yaml/Inline.js
  • lib/yaml/Parser.js
  • lib/yaml/Pattern.js
  • lib/yaml/Unescaper.js
  • lib/yaml/Utils.js
  • lib/yaml/Yaml.js

All Versions

Version Status
2 Unreviewed
1 Rejected