Review of "IP Indicator" version 2

Details Page Preview

A sleek, lightweight GNOME Shell extension to monitor and display your public IP address in the panel (using icanhazip.com). Features auto-refresh, customizable color themes, and manual updates. Crafted by VJECTS (vjects.com).

Extension Homepage
https://github.com/vjects/ip-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:17
            this._box = new St.BoxLayout({
                style_class: 'panel-status-menu-box',
            })
  • extension.js:22
            this._icon = new St.Icon({
                icon_name: 'network-wired-symbolic',
                style_class: 'system-status-icon',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:29
            this._label = new St.Label({
                text: 'Loading...',
                y_align: Clutter.ActorAlign.CENTER,
                style: 'font-weight: bold; margin-left: 6px; margin-right: 6px;'
            })
  • extension.js:36
            this._refreshButton = new St.Button({
                child: new St.Icon({
                    icon_name: 'view-refresh-symbolic',
                    style_class: 'system-status-icon',
                }),
                y_align: Clutter.ActorAlign.CENTER,
                style: 'margin-left: 2px;'
            })

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active
Approved but: 1. Please remove version from the import (line 8 `extension.js`). 2. Please also fix the issues mentioned in the shexli.