Review of "One Thing" version 28

Details Page Preview

Put a single task or goal in your menu bar

Extension Homepage
https://github.com/dantehemerson/one-thing

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • entryMenu.js:24
    Extension.lookupByURL(import.meta.url)
  • widget.js:27
    Extension.lookupByURL(import.meta.url)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • entryMenu.js:23
    St.Clipboard.get_default()

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:66
            this._button_box = new Gtk.Box({
                orientation: Gtk.Orientation.HORIZONTAL,
                valign: Gtk.Align.CENTER,
            })
  • prefs.js:72
            this._leftButton = new Gtk.ToggleButton({
                label: 'Left',
            })
  • prefs.js:75
            this._centerButton = new Gtk.ToggleButton({
                label: 'Center',
                group: this._leftButton,
            })
  • prefs.js:79
            this._rightButton = new Gtk.ToggleButton({
                label: 'Right',
                group: this._leftButton,
            })

All Versions

Previous Reviews on this Version

JustPerfection active