Review of "Do nothing on Lid Close" version 1

Details Page Preview

Toggle laptop lid-close behavior between sleep and active

Extension Homepage
https://github.com/dutaahmad/nothing-on-lid-close

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:40
            this._signalId = this._settings.connect('changed::lid-close-ac-action', () => {
                this._sync();
            })
  • extension.js:30
            this._toggle.connect('clicked', () => {
                if (!this._settings)
                    return;
                const cur = this._settings.get_string('lid-close-ac-action');
                const next = cur === 'suspend' ? 'nothing' : 'suspend';
                this._settings.set_string('lid-close-ac-a

All Versions

Version Status
1 Active

Previous Reviews on this Version

JustPerfection active
Approved but: 1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions