GNOME Shell Extensions

Review of "Desktop Analog Clock" version 3

Details Page Preview

Desktop Analog Clock

by sonersg

Analog clock for GNOME desktop.

Extension Homepage
https://github.com/sonersg/gnome-analog-clock
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:31 
    this._desktopIcon.connect('repaint', this._onRepaint.bind(this))

All Versions

Version Status
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

JustPerfection active
Approved but please remove line 63-66 `extension.js`. Not needed.