Review of "Voluble" version 6

Details Page Preview

Pleasant-sounding announcer of desktop notifications. Give a real voice to GNOME: - Let your GNOME desktop speak and intelligently respond to you. - Reads desktop notifications aloud with human-like voice using Piper. - Can be muted and respects "Do not Disturb". - Reads aloud mouse selection, autodetecting heavily mixed languages. - Summarizes, translates, explains or proofreads selected text using a local LLM. Requires the 'voluble' script, available on GitHub along with setup instructions.

Extension Homepage
https://github.com/QuantiusBenignus/voluble

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:73
    St.Clipboard.get_default()
  • extension.js:83
    St.Clipboard.get_default()
  • extension.js:94
    St.Clipboard.get_default()
  • extension.js:105
    St.Clipboard.get_default()
  • extension.js:115
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:227
    this.itemED = new PopupMenu.PopupMenuItem(this.unmuted ? _('🔇 Mute Voluble') : _('🔊 Unmute Voluble'))

All Versions

Version Status
6 Active
5 Active
4 Active
3 Active
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection active
Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup.